Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ingest): move common host_port validation #6009

Merged
merged 3 commits into from
Sep 22, 2022

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Sep 21, 2022

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Sep 21, 2022
@github-actions
Copy link

github-actions bot commented Sep 21, 2022

Unit Test Results (metadata ingestion)

       8 files  ±0         8 suites  ±0   1h 1m 55s ⏱️ + 2m 47s
   717 tests ±0     714 ✔️ ±0  3 💤 ±0  0 ±0 
1 436 runs  ±0  1 430 ✔️ ±0  6 💤 ±0  0 ±0 

Results for commit 63f6055. ± Comparison against base commit 68db859.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Sep 21, 2022

Unit Test Results (build & test)

562 tests  ±0   562 ✔️ ±0   13m 19s ⏱️ +22s
139 suites ±0       0 💤 ±0 
139 files   ±0       0 ±0 

Results for commit 63f6055. ± Comparison against base commit 68db859.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@rslanka rslanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hsheth2 hsheth2 merged commit 27f2801 into datahub-project:master Sep 22, 2022
@hsheth2 hsheth2 deleted the host-port-refactor branch September 22, 2022 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants