Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ingest): use pydantic utilities for NamingPattern #6013

Merged
merged 3 commits into from
Oct 5, 2022
Merged

refactor(ingest): use pydantic utilities for NamingPattern #6013

merged 3 commits into from
Oct 5, 2022

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Sep 21, 2022

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Sep 21, 2022
@github-actions
Copy link

github-actions bot commented Sep 21, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       8 files  ±0         8 suites  ±0   58m 28s ⏱️ -40s
   717 tests ±0     714 ✔️ ±0  3 💤 ±0  0 ❌ ±0 
1 436 runs  ±0  1 430 ✔️ ±0  6 💤 ±0  0 ❌ ±0 

Results for commit 226efec. ± Comparison against base commit 68db859.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Sep 21, 2022 •
edited
Loading

Unit Test Results (build & test)

562 tests  ±0   562 ✔️ ±0   13m 11s ⏱️ +14s
139 suites ±0       0 💤 ±0 
139 files   ±0       0 ❌ ±0 

Results for commit 226efec. ± Comparison against base commit 68db859.

♻️ This comment has been updated with latest results.

shirshanka
shirshanka approved these changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hsheth2 hsheth2 merged commit 95afc1d into datahub-project:master Oct 5, 2022
@hsheth2 hsheth2 deleted the naming-pattern-cleanup branch October 5, 2022 03:53
david-leifker pushed a commit to david-leifker/datahub that referenced this pull request Oct 6, 2022
@hsheth2 @david-leifker
refactor(ingest): use pydantic utilities for NamingPattern (datahub-p…
53033e3 
…roject#6013)

* refactor(ingest): use pydantic utilities for NamingPattern

* clean up replacement logic

* flatten config hierarchy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsheth2 @shirshanka