Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ingest): aws - support extra args to role config #6031

Merged
merged 1 commit into from
Sep 23, 2022

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Sep 22, 2022

  • Adds support for external_id and other options in assume_role
  • Makes it possible to use assume_role in conjunction with the other credential configs.
  • Improves docs for all AWS config options.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Sep 22, 2022
@github-actions
Copy link

Unit Test Results (metadata ingestion)

    5 files    5 suites   41m 1s ⏱️
  52 tests 49 ✔️ 3 💤 0
103 runs  98 ✔️ 5 💤 0

Results for commit 8fca0c8.

@github-actions
Copy link

Unit Test Results (build & test)

562 tests  ±0   562 ✔️ ±0   12m 54s ⏱️ -52s
139 suites ±0       0 💤 ±0 
139 files   ±0       0 ±0 

Results for commit 8fca0c8. ± Comparison against base commit 63ef9c0.

@hsheth2 hsheth2 changed the title feat(ingest): support extra args to role config feat(ingest): support extra args to AWS role config Sep 23, 2022
@shirshanka shirshanka changed the title feat(ingest): support extra args to AWS role config feat(ingest): aws - support extra args to role config Sep 23, 2022
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit 3a6d1d2 into datahub-project:master Sep 23, 2022
@hsheth2 hsheth2 deleted the aws-role-config branch February 14, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants