-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ingest): add column-level lineage support for snowflake #6034
feat(ingest): add column-level lineage support for snowflake #6034
Conversation
- also fixes issue with view upstream lineage
Unit Test Results (metadata ingestion) 8 files ±0 8 suites ±0 1h 0m 58s ⏱️ -33s Results for commit 75e71c7. ± Comparison against base commit 0728656. This pull request removes 8 and adds 10 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Unit Test Results (build & test)584 tests +16 580 ✔️ +16 12m 54s ⏱️ -2s Results for commit 75e71c7. ± Comparison against base commit 0728656. This pull request removes 9 and adds 25 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
metadata-ingestion/src/datahub/ingestion/source/snowflake/snowflake_lineage.py
Show resolved
Hide resolved
view_name, | ||
db_row["VIEW_COLUMNS"], | ||
db_row["DOWNSTREAM_TABLE_COLUMNS"], | ||
json.loads(db_row["VIEW_COLUMNS"]), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what happens if this bombs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, I don't expect bombing since the VIEW_COLUMNS
column is equivalent to columns
json array as per snowflake access history view documentation and the dict to class conversion is protected already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have some questions around __eq__
and __hash__
metadata-ingestion/src/datahub/ingestion/source/snowflake/snowflake_lineage.py
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/snowflake/snowflake_lineage.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Other changes
Note:
Checklist