-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ingest): list referenced env variables in recipe #6043
Conversation
Unit Test Results (metadata ingestion) 8 files ±0 8 suites ±0 56m 41s ⏱️ - 1m 51s Results for commit 623ca4d. ± Comparison against base commit 325b959. This pull request removes 8 and adds 8 tests. Note that renamed tests count towards both.
|
@@ -51,6 +52,19 @@ def resolve_env_variables(config: dict) -> dict: | |||
return new_dict | |||
|
|||
|
|||
def list_referenced_env_variables(config: dict) -> Set[str]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see this function being used anywhere (other than the test). So what's the purpose of this function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we want to fetch secrets from an external secret store rather than env vars, we'll need to be able to list the required variables. This function will be used by the acryl executor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Checklist