-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ingest): bigquery-beta - Additional fixes for Bigquery beta #6051
fix(ingest): bigquery-beta - Additional fixes for Bigquery beta #6051
Conversation
- Apply lineage extraction enable parameter for views as well - Range partitioned tables are partitioned on the last partition - Making lineage parser exceptions less verbose to don't freak out users - Fixing invalid partition in report
partition_column: Optional[BigqueryColumn] = None | ||
for column in table.columns: | ||
if column.is_partition_column: | ||
partition_column = column |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can there be multiple partition columns?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BigQuery only supports partitioning on one column.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Checklist