Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(frontend): Adding support to show externalUrl and institutionalMemoryFields for MLModels #6053

Merged
merged 7 commits into from
Nov 15, 2022
Merged

feat(frontend): Adding support to show externalUrl and institutionalMemoryFields for MLModels #6053

merged 7 commits into from
Nov 15, 2022

Conversation

lurecas
Copy link
Contributor

@lurecas lurecas commented Sep 26, 2022

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@lurecas lurecas changed the title feat(frontend) Adding support to show externalUrl and institutionalMemoryFields for MLModels feat(frontend): Adding support to show externalUrl and institutionalMemoryFields for MLModels Sep 26, 2022
@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Sep 26, 2022
@maggiehays maggiehays added the community-contribution PR or Issue raised by member(s) of DataHub Community label Sep 28, 2022
@shirshanka shirshanka requested a review from gabe-lyons October 5, 2022 04:05
@github-actions
Copy link

github-actions bot commented Oct 5, 2022 •
edited
Loading

Unit Test Results (build & test)

597 tests  ±0   593 ✔️ ±0   12m 0s ⏱️ -4s
147 suites ±0       4 💤 ±0 
147 files   ±0       0 ❌ ±0 

Results for commit da1a128. ± Comparison against base commit abe6781.

♻️ This comment has been updated with latest results.

@lurecas
Copy link
Contributor Author

lurecas commented Oct 5, 2022

@shirshanka I've fixed the linting problem on the .tsx file. Sorry for not run the test beforehand.
On the other hand, I've run the other faulty test suite (running the check spark-lineage jar, but locally works ok.
Thanks!

@maaaikoool
Copy link
Contributor

Could we please merge this @shirshanka ? Many thanks!

@aditya-radhakrishnan aditya-radhakrishnan merged commit 8395016 into datahub-project:master Nov 15, 2022
@aditya-radhakrishnan
Copy link
Contributor

Thank you for the contribution! Sorry for the delay, but just merged :)

cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023
@lurecas @gabe-lyons @cccs-Dustin
feat(frontend): Adding support to show externalUrl and institutionalM…
88db68c 
…emoryFields for MLModels (datahub-project#6053)

* adding externalUrl to MLModelProperty graphQL entity

* Adding externalUrl mapping for MLModelProperties

* adding externalUrl to the GraphQL frontend query

* adding institutionalMemory to the MLModel GraphQL query

* mapping externalUrl as property on the tsx template for MLModel

* fixing lint issues on MLModelEntity.tsx

Co-authored-by: Luis Redondo Cañada <[email protected]>
Co-authored-by: Gabe Lyons <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabe-lyons gabe-lyons gabe-lyons approved these changes

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lurecas @maaaikoool @aditya-radhakrishnan @gabe-lyons @maggiehays