feat(advanced search): Add component to show all advanced search filters & add new filter #6058
Conversation
| ), | ||
| }} | ||
| labelInValue | ||
| style={{ padding: 6, fontWeight: 500 }} |
There was a problem hiding this comment.
I know we're trying to use styled components across our React app, can we do that here instead?
There was a problem hiding this comment.
ach I wanted to do that here too but the antd Select was overwriting them
| .sort((a, b) => FIELD_TO_LABEL[a].localeCompare(FIELD_TO_LABEL[b])) | ||
| .map((key) => ( | ||
| <Option | ||
| disabled={key === 'entity' && !!selectedFilters.find((filter) => filter.field === 'entity')} |
There was a problem hiding this comment.
what is this function doing? It's a bit hard to tell what's going on
| <StyledSelect | ||
| showArrow={false} | ||
| bordered={false} | ||
| value={unionType === UnionType.AND ? 'all filters' : 'any filter'} |
There was a problem hiding this comment.
can we make these strings consts?
There was a problem hiding this comment.
this is just for display purposes, so i dont think thats needed (the actual constant is UnionType). Adding a comment
| border-radius: 5px; | ||
| background: ${ANTD_GRAY[4]}; | ||
| :hover { | ||
| background: ${ANTD_GRAY[4.5]}; |
There was a problem hiding this comment.
does this 4 vs 4.5 make a substantial visual difference?
| const newFilter: FacetFilterInput = { | ||
| field: filterField, | ||
| values: values as string[], | ||
| value: '', // TODO(Gabe): remove once we refactor the model |
There was a problem hiding this comment.
is this a todo for after this pr?
| values: values as string[], | ||
| value: '', // TODO(Gabe): remove once we refactor the model | ||
| condition: | ||
| FIELDS_THAT_USE_CONTAINS_OPERATOR.indexOf(filterField) > -1 |
There was a problem hiding this comment.
can we use .includes again?
gabe-lyons
force-pushed
the
gabe--addingAdvancedSearchFiltersComponent
branch
from
d6d745d to
1cb0d20
Compare
This pr adds the root component for advanced search, including add a new filter & choose union type (AND vs OR)
Checklist