fix(mae-consumer): fix regression on base64 encoding #6061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
devops
|
Thank you for this PR @codesorcery, this was an oversight on my part! Weird that during testing this was not caught... The smoke tests don't seem to be passing. Are you able to take a look? |
|
Hey @pedro93 , found some small mistakes within my changes. Shouldn't really have anything to do with the failing smoke tests, but let's see if this already fixes the tests. |
Pull request #5827 introduced a regression by removing coreutils from the mae-consumer Dockerfile (coreutils was added in #3723). This broke the base64 call in the startup script s.th. the Elasticsearch auth header will not be correctly set when username and password are provided. To make sure that the startup script fails on these errors in the future, set "-euo pipefail" which lets the bash script fail on errors and unset variables. Also refactor the startup script to make it more stable and readable.
maggiehays
added
the
community-contribution
pedro93
approved these changes
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request #5827 introduced a regression by removing
coreutilsfrom themae-consumerDockerfile (coreutils was added in #3723). This broke thebase64call in the startup script s.th. the Elasticsearch auth header will not be correctly set when username and password are provided.To make sure that the startup script fails on these errors in the future, set
-euo pipefailwhich lets the bash script fail on errors and unset variables. Also refactor the startup script to make it more stable and readable.