Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): Closeable as a context manager #6067

Merged
merged 4 commits into from
Oct 13, 2022
Merged

fix(ingest): Closeable as a context manager #6067

merged 4 commits into from
Oct 13, 2022

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Sep 27, 2022

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@hsheth2 hsheth2 changed the title fix(ingest): allow Closeable to be as a context manager fix(ingest): Closeable as a context manager Sep 27, 2022
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Sep 27, 2022
@github-actions
Copy link

github-actions bot commented Sep 27, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       8 files  ±0         8 suites  ±0   58m 50s ⏱️ +30s
   736 tests +4     734 ✔️ +4  2 💤 ±0  0 ❌ ±0 
1 474 runs  +8  1 470 ✔️ +8  4 💤 ±0  0 ❌ ±0 

Results for commit dc7c178. ± Comparison against base commit c7cc0af.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Sep 27, 2022 •
edited
Loading

Unit Test Results (build & test)

597 tests  ±0   593 ✔️ ±0   11m 39s ⏱️ -17s
147 suites ±0       4 💤 ±0 
147 files   ±0       0 ❌ ±0 

Results for commit dc7c178. ± Comparison against base commit c7cc0af.

♻️ This comment has been updated with latest results.

shirshanka
shirshanka approved these changes Oct 7, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shirshanka
shirshanka previously requested changes Oct 7, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like CI failures are real.

@hsheth2 hsheth2 dismissed shirshanka’s stale review October 13, 2022 19:49

Issue was resolved

@hsheth2 hsheth2 merged commit 521e61d into datahub-project:master Oct 13, 2022
@hsheth2 hsheth2 deleted the context-manager-closeable branch October 13, 2022 19:49
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
@hsheth2 @cccs-tom
fix(ingest): Closeable as a context manager (datahub-project#6067)
d1e3355
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
@hsheth2 @cccs-tom
fix(ingest): Closeable as a context manager (datahub-project#6067)
7b904ec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-leifker david-leifker david-leifker approved these changes

@aditya-radhakrishnan aditya-radhakrishnan aditya-radhakrishnan approved these changes

@shirshanka shirshanka shirshanka left review comments

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hsheth2 @shirshanka @aditya-radhakrishnan @david-leifker