Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(ingest): clarify bigquery-beta multiproject setup #6071

Merged
merged 4 commits into from
Sep 28, 2022
Merged

docs(ingest): clarify bigquery-beta multiproject setup #6071

merged 4 commits into from
Sep 28, 2022

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Sep 27, 2022

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Sep 27, 2022
@github-actions
Copy link

github-actions bot commented Sep 27, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       8 files         8 suites   59m 30s ⏱️
   719 tests    716 ✔️ 3 💤 0 ❌
1 440 runs  1 434 ✔️ 6 💤 0 ❌

Results for commit d0c5049.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Sep 27, 2022 •
edited
Loading

Unit Test Results (build & test)

584 tests  ±0   580 ✔️ ±0   12m 53s ⏱️ -3s
143 suites ±0       4 💤 ±0 
143 files   ±0       0 ❌ ±0 

Results for commit d0c5049. ± Comparison against base commit eae86a6.

♻️ This comment has been updated with latest results.

shirshanka
shirshanka approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit 7e08a05 into datahub-project:master Sep 28, 2022
@hsheth2 hsheth2 deleted the bigquery-docs branch September 28, 2022 15:56
shirshanka pushed a commit to shirshanka/datahub that referenced this pull request Sep 29, 2022
@hsheth2 @shirshanka
docs(ingest): clarify bigquery-beta multiproject setup (datahub-proje…
b804516 
…ct#6071)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsheth2 @shirshanka