Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(elastic-setup) Fixing env var logic #6079

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

pedro93
Copy link
Collaborator

@pedro93 pedro93 commented Sep 28, 2022

Fixes #6060, tested locally by reproducing issue with Quickstart, building the updated image and deploying it using quickstart.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the devops PR or Issue related to DataHub backend & deployment label Sep 28, 2022
@github-actions
Copy link

Unit Test Results (build & test)

584 tests  ±0   580 ✔️ ±0   12m 49s ⏱️ - 1m 9s
143 suites ±0       4 💤 ±0 
143 files   ±0       0 ±0 

Results for commit c0e8ec1. ± Comparison against base commit 09dec1a.

Copy link
Collaborator

@anshbansal anshbansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anshbansal anshbansal merged commit f83eb6f into datahub-project:master Sep 29, 2022
@anshbansal anshbansal deleted the fix-elasticsearch branch September 29, 2022 05:23
@pedro93 pedro93 mentioned this pull request Oct 5, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops PR or Issue related to DataHub backend & deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

datahub-elasticsearch-setup-job fails to start in GKE
2 participants