Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest): alias for mssql-odbc source #6080

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Sep 28, 2022

Slack ref: https://datahubspace.slack.com/archives/CUMUWQU66/p1664374799979859?thread_ts=1664289608.112209&cid=CUMUWQU66

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Sep 28, 2022
@github-actions
Copy link

Unit Test Results (build & test)

534 tests   - 50   529 ✔️  - 51   13m 34s ⏱️ -24s
124 suites  - 19       4 💤 ±  0 
124 files    - 19       1 +  1 

For more details on these failures, see this check.

Results for commit d6e6fa2. ± Comparison against base commit 09dec1a.

This pull request removes 50 tests.
datahub.protobuf.ProtobufDatasetTest ‑ customFieldVisitors
datahub.protobuf.ProtobufDatasetTest ‑ duplicateNested
datahub.protobuf.ProtobufDatasetTest ‑ googleTimestamp
datahub.protobuf.ProtobufDatasetTest ‑ messageA
datahub.protobuf.ProtobufDatasetTest ‑ messageB
datahub.protobuf.ProtobufDatasetTest ‑ messageC
datahub.protobuf.ProtobufDatasetTest ‑ messageC2NestedOneOf
datahub.protobuf.ProtobufDatasetTest ‑ noSchemaTest
datahub.protobuf.ProtobufDatasetTest ‑ platformSchemaTest
datahub.protobuf.ProtobufUtilsTest ‑ registryTest
…

@github-actions
Copy link

Unit Test Results (metadata ingestion)

       5 files         5 suites   32m 42s ⏱️
   719 tests    716 ✔️ 3 💤 0
1 387 runs  1 384 ✔️ 3 💤 0

Results for commit d6e6fa2.

Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@treff7es treff7es merged commit 71f5ec7 into datahub-project:master Sep 29, 2022
@hsheth2 hsheth2 deleted the mssql-alias branch February 14, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants