Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(schema filter): fix schema infinite rerender #6082

Merged
merged 1 commit into from
Sep 29, 2022
Merged

fix(schema filter): fix schema infinite rerender #6082

merged 1 commit into from
Sep 29, 2022

Conversation

gabe-lyons
Copy link
Contributor

If no expandedRowsFromFilter is provided then the schema will infinite rerender. This breaks Chart pages for Looker charts with inputs.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Sep 28, 2022
@github-actions
Copy link

Unit Test Results (build & test)

584 tests  ±0   580 ✔️ ±0   12m 48s ⏱️ - 1m 10s
143 suites ±0       4 💤 ±0 
143 files   ±0       0 ❌ ±0 

Results for commit 52934c0. ± Comparison against base commit 09dec1a.

@jjoyce0510 jjoyce0510 merged commit 8163e1c into datahub-project:master Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aditya-radhakrishnan aditya-radhakrishnan aditya-radhakrishnan approved these changes

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

Assignees
No one assigned
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabe-lyons @jjoyce0510 @aditya-radhakrishnan