feat(monitoring): track graphql errors in metrics #6087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjoyce0510
reviewed
Sep 29, 2022
| @@ -126,9 +126,20 @@ void getGraphQL(HttpServletRequest request, HttpServletResponse response) { | |||
| throw new UnsupportedOperationException("GraphQL gets not supported."); | |||
| } | |||
|
|
|||
| private void observeErrors(ExecutionResult executionResult) { | |||
| executionResult.getErrors().forEach(graphQLError -> { | |||
| String errorType = graphQLError.getErrorType().toString(); | |||
There was a problem hiding this comment.
So we also have our own exception type called DataHubGraphQLError that has an "error code" field. This would be useful to extract as it can show error codes like 401, 404, 500 etc.
If the first error is not an instance of DataHubGraphQLError, then we can increment he "500" error code bucket
There was a problem hiding this comment.
I'm seeing metrics like this if I run it locally:
metrics_com_datahub_graphql_GraphQLController_errorType_DataFetchingException_Count
DataFetchingException is the result of DataHubGraphQLError.getErrorType(): here
There was a problem hiding this comment.
Is that what you meant?
…nto measure-graphql-errors
jjoyce0510
reviewed
Sep 29, 2022
metadata-service/graphql-servlet-impl/src/main/java/com/datahub/graphql/GraphQLController.java
Show resolved
Hide resolved
jjoyce0510
approved these changes
Sep 29, 2022
|
Actually - looks like compilation is failing. Please address first! |
RyanHolstien
approved these changes
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist