Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(frontend): add custom ssl truststore settings #6090

Merged
merged 2 commits into from
Oct 14, 2022
Merged

feat(frontend): add custom ssl truststore settings #6090

merged 2 commits into from
Oct 14, 2022

Conversation

alexey-kravtsov
Copy link
Contributor

@alexey-kravtsov alexey-kravtsov commented Sep 29, 2022 •
edited
Loading

Add custom truststore settings. It is required for frontend to use self-signed certificates to connect 3rd party services

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the devops PR or Issue related to DataHub backend & deployment label Sep 29, 2022
@alexey-kravtsov
Copy link
Contributor Author

We set up JAAS LDAP authentication and use self-signed certificates for LDAP. Earlier we were passing truststore options via JAVA_OPTS, like -Djavax.net.ssl.trustStore=... but now start.sh overrides this env variable. I've added these options separately

@github-actions
Copy link

github-actions bot commented Sep 29, 2022 •
edited
Loading

Unit Test Results (build & test)

584 tests  ±0   580 ✔️ ±0   12m 55s ⏱️ +3s
143 suites ±0       4 💤 ±0 
143 files   ±0       0 ❌ ±0 

Results for commit 566d2ba. ± Comparison against base commit 4792ac5.

♻️ This comment has been updated with latest results.

@maggiehays maggiehays added the community-contribution PR or Issue raised by member(s) of DataHub Community label Oct 13, 2022
shirshanka
shirshanka approved these changes Oct 14, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit 961efe9 into datahub-project:master Oct 14, 2022
@alexey-kravtsov alexey-kravtsov deleted the ssl-options branch October 16, 2022 07:42
@maggiehays maggiehays added the hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ label Oct 21, 2022
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
@alexey-kravtsov @cccs-tom
feat(frontend): add custom ssl truststore settings (datahub-project#6090
55f70aa 
)
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
@alexey-kravtsov @cccs-tom
feat(frontend): add custom ssl truststore settings (datahub-project#6090
8882fb4 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

@aditya-radhakrishnan aditya-radhakrishnan Awaiting requested review from aditya-radhakrishnan

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community devops PR or Issue related to DataHub backend & deployment hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexey-kravtsov @shirshanka @maggiehays