Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): lookml - extract column correctly #6093

Merged
merged 1 commit into from
Sep 30, 2022
Merged

fix(ingest): lookml - extract column correctly #6093

merged 1 commit into from
Sep 30, 2022

Conversation

shirshanka
Copy link
Contributor

@shirshanka shirshanka commented Sep 30, 2022 •
edited
Loading

Regex was overly broad and matching whitespace as well.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Sep 30, 2022
@github-actions
Copy link

Unit Test Results (metadata ingestion)

       8 files  ±0         8 suites  ±0   56m 29s ⏱️ -14s
   719 tests ±0     716 ✔️ ±0  3 💤 ±0  0 ❌ ±0 
1 440 runs  ±0  1 434 ✔️ ±0  6 💤 ±0  0 ❌ ±0 

Results for commit f2d374f. ± Comparison against base commit 446b10d.

@github-actions
Copy link

Unit Test Results (build & test)

584 tests  ±0   580 ✔️ ±0   12m 49s ⏱️ -22s
143 suites ±0       4 💤 ±0 
143 files   ±0       0 ❌ ±0 

Results for commit f2d374f. ± Comparison against base commit 446b10d.

treff7es
treff7es approved these changes Sep 30, 2022
View reviewed changes
Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@treff7es treff7es merged commit 3d8d8c6 into datahub-project:master Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treff7es treff7es treff7es approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shirshanka @treff7es