Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest): add async option to ingest proposal endpoint #6097

Merged
merged 3 commits into from
Oct 4, 2022
Merged

feat(ingest): add async option to ingest proposal endpoint #6097

merged 3 commits into from
Oct 4, 2022

Conversation

RyanHolstien
Copy link
Collaborator

@RyanHolstien RyanHolstien commented Sep 30, 2022 •
edited
Loading

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata product PR or Issue related to the DataHub UI/UX labels Sep 30, 2022
@github-actions
Copy link

github-actions bot commented Sep 30, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       8 files         8 suites   57m 10s ⏱️
   719 tests    716 ✔️ 3 💤 0 ❌
1 440 runs  1 434 ✔️ 6 💤 0 ❌

Results for commit 4015769.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Sep 30, 2022 •
edited
Loading

Unit Test Results (build & test)

584 tests  ±0   580 ✔️ ±0   13m 18s ⏱️ -11s
143 suites ±0       4 💤 ±0 
143 files   ±0       0 ❌ ±0 

Results for commit 4015769. ± Comparison against base commit 79575b2.

♻️ This comment has been updated with latest results.

shirshanka
shirshanka approved these changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Check if you can avoid the transition thru the renameNamespace operation while serializing to avro.

@RyanHolstien RyanHolstien merged commit bfb903c into datahub-project:master Oct 4, 2022
@RyanHolstien RyanHolstien deleted the feat/asyncIngestEndpoint branch October 4, 2022 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

@jjoyce0510 jjoyce0510 Awaiting requested review from jjoyce0510

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RyanHolstien @shirshanka