Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(posts): add posts feature to DataHub #6110

Merged
merged 1 commit into from
Oct 4, 2022
Merged

feat(posts): add posts feature to DataHub #6110

merged 1 commit into from
Oct 4, 2022

Conversation

aditya-radhakrishnan
Copy link
Contributor

@aditya-radhakrishnan aditya-radhakrishnan commented Oct 3, 2022 •
edited
Loading

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Oct 3, 2022
@github-actions
Copy link

github-actions bot commented Oct 4, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       8 files  ±0         8 suites  ±0   1h 0m 21s ⏱️ - 1m 2s
   719 tests ±0     716 ✔️ ±0  3 💤 ±0  0 ❌ ±0 
1 440 runs  ±0  1 434 ✔️ ±0  6 💤 ±0  0 ❌ ±0 

Results for commit f9f04ca. ± Comparison against base commit 3c0f63c.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 4, 2022 •
edited
Loading

Unit Test Results (build & test)

591 tests  +7   587 ✔️ +7   13m 25s ⏱️ +34s
146 suites +3       4 💤 ±0 
146 files   +3       0 ❌ ±0 

Results for commit f9f04ca. ± Comparison against base commit 3c0f63c.

♻️ This comment has been updated with latest results.

jjoyce0510
jjoyce0510 reviewed Oct 4, 2022
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple questions / concerns... Otherwise looks good in general!

@aditya-radhakrishnan aditya-radhakrishnan merged commit ee1a1ef into datahub-project:master Oct 4, 2022
@aditya-radhakrishnan aditya-radhakrishnan deleted the ar--pinned branch October 4, 2022 22:37
david-leifker pushed a commit to david-leifker/datahub that referenced this pull request Oct 6, 2022
@aditya-radhakrishnan @david-leifker
feat(posts): add posts feature to DataHub (datahub-project#6110)
20eec38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 left review comments

@gabe-lyons gabe-lyons gabe-lyons approved these changes

@chriscollins3456 chriscollins3456 Awaiting requested review from chriscollins3456

Assignees
No one assigned
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aditya-radhakrishnan @gabe-lyons @jjoyce0510