Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest): ignore usage and operation for snowflake datasets withou… #6112

Conversation

mayurinehate
Copy link
Collaborator

…t schema

Currently if role has access to account usage tables, usage for all tables (including deleted and not accessible tables) are ingested. This PR takes care not to ingest usage for such datasets in datahub. Usage will be ingested only for tables for which schema is accessible.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

…t schema

Currently if role has access to account usage tables, usage for all tables (including deleted
and not accessible tables) are ingested. This PR takes care not to ingest usage for
such datasets in datahub.
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Oct 4, 2022
@github-actions
Copy link

github-actions bot commented Oct 4, 2022

Unit Test Results (metadata ingestion)

       8 files         8 suites   56m 3s ⏱️
   719 tests    716 ✔️ 3 💤 0
1 440 runs  1 434 ✔️ 6 💤 0

Results for commit e7fd801.

@github-actions
Copy link

github-actions bot commented Oct 4, 2022

Unit Test Results (build & test)

584 tests  ±0   580 ✔️ ±0   13m 34s ⏱️ +38s
143 suites ±0       4 💤 ±0 
143 files   ±0       0 ±0 

Results for commit e7fd801. ± Comparison against base commit bea5a07.

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit 4ee3ef1 into datahub-project:master Oct 5, 2022
david-leifker pushed a commit to david-leifker/datahub that referenced this pull request Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants