Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mae): use JAVA_TOOL_OPTIONS instead of JDK_JAVA_OPTIONS #6114

Merged
merged 1 commit into from
Oct 4, 2022
Merged

fix(mae): use JAVA_TOOL_OPTIONS instead of JDK_JAVA_OPTIONS #6114

merged 1 commit into from
Oct 4, 2022

Conversation

szalai1
Copy link
Contributor

@szalai1 szalai1 commented Oct 4, 2022

JDK_JAVA_OPTIONS is loaded twice by java (probably alpine bug).
As a workaround using: JAVA_TOOL_OPTIONS

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@szalai1
fix(mae): use JAVA_TOOL_OPTIONS instead of JDK_JAVA_OPTIONS
3b856ab 
JDK_JAVA_OPTIONS is loaded twice by java (probably alpine bug).
As a workaround using: JAVA_TOOL_OPTIONS
@github-actions github-actions bot added the devops PR or Issue related to DataHub backend & deployment label Oct 4, 2022
pedro93
pedro93 approved these changes Oct 4, 2022
View reviewed changes
Copy link
Collaborator

@pedro93 pedro93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let’s wait for a green CI

@github-actions
Copy link

github-actions bot commented Oct 4, 2022

Unit Test Results (build & test)

584 tests  ±0   580 ✔️ ±0   13m 38s ⏱️ +42s
143 suites ±0       4 💤 ±0 
143 files   ±0       0 ❌ ±0 

Results for commit 3b856ab. ± Comparison against base commit bea5a07.

@shirshanka shirshanka merged commit 396fd31 into master Oct 4, 2022
@shirshanka shirshanka deleted the fix-mae-jdk-env-var branch October 4, 2022 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedro93 pedro93 pedro93 approved these changes

Assignees
No one assigned
Labels
devops PR or Issue related to DataHub backend & deployment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@szalai1 @pedro93 @shirshanka