Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingestion): fix percent change computation in stale_entity_removal #6121

Merged
merged 1 commit into from
Oct 5, 2022
Merged

fix(ingestion): fix percent change computation in stale_entity_removal #6121

merged 1 commit into from
Oct 5, 2022

Conversation

rslanka
Copy link
Contributor

@rslanka rslanka commented Oct 4, 2022

  1. Fixes the bug in percent change computation for stale entity removal
  2. Changes the fail_safe_threshold value to 20.0 from 95.0 per our discussion.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@rslanka rslanka requested a review from hsheth2 October 4, 2022 23:33
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Oct 4, 2022
@github-actions
Copy link

github-actions bot commented Oct 4, 2022

Unit Test Results (metadata ingestion)

       8 files  ±  0         8 suites  ±0   56m 46s ⏱️ - 1m 14s
   728 tests +  9     725 ✔️ +  9  3 💤 ±0  0 ❌ ±0 
1 458 runs  +18  1 452 ✔️ +18  6 💤 ±0  0 ❌ ±0 

Results for commit 5c43c41. ± Comparison against base commit ee1a1ef.

@github-actions
Copy link

github-actions bot commented Oct 5, 2022

Unit Test Results (build & test)

591 tests  ±0   587 ✔️ ±0   13m 43s ⏱️ +33s
146 suites ±0       4 💤 ±0 
146 files   ±0       0 ❌ ±0 

Results for commit 5c43c41. ± Comparison against base commit ee1a1ef.

@hsheth2 hsheth2 changed the title fix(ingestion): Fix percent change computation in stale_entity_removal & default value of threshold fix(ingestion): fix percent change computation in stale_entity_removal Oct 5, 2022
@hsheth2 hsheth2 merged commit 055e408 into datahub-project:master Oct 5, 2022
david-leifker pushed a commit to david-leifker/datahub that referenced this pull request Oct 6, 2022
@rslanka @david-leifker
fix(ingestion): fix percent change computation in stale_entity_removal (
cc7152b 
datahub-project#6121)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees

@hsheth2 hsheth2

Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rslanka @hsheth2