feat(tracking): add telemetry for frontend events #6129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabe-lyons
reviewed
Oct 6, 2022
| response.getEntity().toString())); | ||
| } | ||
| } catch (Exception e) { | ||
| throw new RuntimeException("Failed to verify credentials for user", e); |
There was a problem hiding this comment.
Failed to verify credentials for user is this the right error message?
There was a problem hiding this comment.
No it's not, updated!
gabe-lyons
reviewed
Oct 6, 2022
| throw new RuntimeException("Failed to verify credentials for user", e); | ||
| } finally { | ||
| try { | ||
| httpClient.close(); |
There was a problem hiding this comment.
do we need to open & close this client each time we make a request? theres no re-usable client?
There was a problem hiding this comment.
Refactored to use one client
gabe-lyons
reviewed
Oct 6, 2022
|
|
||
| @Nonnull | ||
| JSONObject sanitizeEvent(@Nonnull final JsonNode event) { | ||
| final JSONObject eventObj; |
There was a problem hiding this comment.
for the sake of no confusion, would be good to call this unsanitizedEventObj
There was a problem hiding this comment.
Good call, renamed
aditya-radhakrishnan
force-pushed
the
ar--oss-telemetry
branch
from
953a4c1 to
24fedeb
Compare
aditya-radhakrishnan
force-pushed
the
ar--oss-telemetry
branch
from
24fedeb to
9500ce3
Compare
gabe-lyons
reviewed
Oct 6, 2022
| try { | ||
| bodyJson = mapper.readTree(jsonStr); | ||
| } catch (JsonProcessingException e) { | ||
| log.error(String.format("Failed to parse json while attempting to create native user %s", jsonStr)); |
gabe-lyons
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist