Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): bigquery-beta - fix for missing key error if dataset list was empty #6133

Merged
merged 1 commit into from
Oct 6, 2022
Merged

fix(ingest): bigquery-beta - fix for missing key error if dataset list was empty #6133

merged 1 commit into from
Oct 6, 2022

Conversation

treff7es
Copy link
Contributor

@treff7es treff7es commented Oct 6, 2022

  • updating bigquery permission doc
  • adding some more context if no dataset or project returned

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@treff7es
- fix for missing key error if dataset was empty
77162f3 
- updating bigquery permission doc
- adding some more context if no dataset or project returned
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Oct 6, 2022
@github-actions
Copy link

github-actions bot commented Oct 6, 2022

Unit Test Results (metadata ingestion)

       8 files         8 suites   54m 41s ⏱️
   732 tests    727 ✔️ 3 💤 2 ❌
1 466 runs  1 456 ✔️ 6 💤 4 ❌

For more details on these failures, see this check.

Results for commit 77162f3.

@github-actions
Copy link

github-actions bot commented Oct 6, 2022

Unit Test Results (build & test)

591 tests  ±0   587 ✔️ ±0   13m 28s ⏱️ +41s
146 suites ±0       4 💤 ±0 
146 files   ±0       0 ❌ ±0 

Results for commit 77162f3. ± Comparison against base commit 928f294.

shirshanka
shirshanka approved these changes Oct 6, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit 6db0925 into datahub-project:master Oct 6, 2022
@treff7es treff7es deleted the bq_key_error_fix branch February 8, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@treff7es @shirshanka