Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(search): temporarily disable fetching input fields for search results #6139

Conversation

gabe-lyons
Copy link
Contributor

@gabe-lyons gabe-lyons commented Oct 6, 2022

We fetch input fields to enrich search snippets when relevant, but its causing some perf issues for large dashboards. Temporarily disabling that fetch for now.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Oct 6, 2022
@github-actions
Copy link

github-actions bot commented Oct 6, 2022

Unit Test Results (build & test)

591 tests  ±0   587 ✔️ ±0   12m 7s ⏱️ -13s
146 suites ±0       4 💤 ±0 
146 files   ±0       0 ±0 

Results for commit 0890404. ± Comparison against base commit 485d569.

@gabe-lyons gabe-lyons merged commit 5f0216c into datahub-project:master Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants