feat(ingestion): business-glossary - Add values and relatedTerms support #6148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
siddiquebagwan
changed the title
…ue/datahub into master+acr-4365-model-changes
…datahub-fork into master+acr-4365-model-changes
…s get set to None
…datahub-fork into master+acr-4365-model-changes
…datahub-fork into master+acr-4365-model-changes
…datahub-fork into master+acr-4365-model-changes
gabe-lyons
reviewed
Oct 25, 2022
| "boostScore": 2.0 | ||
| } | ||
| } | ||
| hasRelatedTermValues: optional array[GlossaryTermUrn] |
There was a problem hiding this comment.
this should just be called values
gabe-lyons
reviewed
Oct 25, 2022
| "boostScore": 2.0 | ||
| } | ||
| } | ||
| isRelatedToTerms: optional array[GlossaryTermUrn] |
gabe-lyons
reviewed
Oct 25, 2022
| term_source: "EXTERNAL" | ||
| source_ref: FIBO | ||
| source_url: "https://spec.edmcouncil.org/fibo/ontology/FBC/ProductsAndServices/ClientsAndAccounts/Account" | ||
| has_value: |
There was a problem hiding this comment.
lets call this key values
gabe-lyons
reviewed
Oct 25, 2022
| term_source: "EXTERNAL" | ||
| source_ref: FIBO | ||
| source_url: "https://spec.edmcouncil.org/fibo/ontology/FBC/ProductsAndServices/ClientsAndAccounts/Account" | ||
| is_related_to: |
There was a problem hiding this comment.
call this key related_to
There was a problem hiding this comment.
or just related_terms
shirshanka
reviewed
Oct 31, 2022
| @@ -41,6 +45,8 @@ class GlossaryTermConfig(ConfigModel): | |||
| owners: Optional[Owners] | |||
| inherits: Optional[List[str]] | |||
| contains: Optional[List[str]] | |||
There was a problem hiding this comment.
let's add an additional Optional str field called id, which if present will be used as the id for the term. The id can be provided in urn:li:.. form or in bare form.
shirshanka
reviewed
Oct 31, 2022
| @@ -66,6 +72,8 @@ class DefaultConfig(ConfigModel): | |||
|
|
|||
| class BusinessGlossarySourceConfig(ConfigModel): | |||
| file: str = Field(description="Path to business glossary file to ingest.") | |||
| enable_datahub_guid: bool = Field( | |||
There was a problem hiding this comment.
Suggest renaming this field to enable_auto_id to line up with the suggested id field for terms and term groups.
shirshanka
reviewed
Oct 31, 2022
| return v | ||
|
|
||
|
|
||
| def create_id(path: List[str], enable_datahub_guid: bool) -> str: |
There was a problem hiding this comment.
this should additionally take in the Optional id.
shirshanka
reviewed
Oct 31, 2022
| "boostScore": 2.0 | ||
| } | ||
| } | ||
| hasRelatedTermValues: optional array[GlossaryTermUrn] |
…datahub-fork into master+acr-4365-model-changes
…datahub-fork into master+acr-4365-model-changes
siddiquebagwan
changed the title
gabe-lyons
approved these changes
Nov 1, 2022
|
Cannot reproduce the datahub-ingestion docker issue locally- I believe it is spurious. Merging through. |
cccs-tom
pushed a commit
to CybercentreCanada/datahub
that referenced
this pull request
Nov 18, 2022
…ort (datahub-project#6148) * WIP * updated snapshot * merge * while creating BusinessGlossaryConfig object, the version field always get set to None * WIP * lint fix * remove field * doc update * rename the fields * review comments * lintFix * Fix the business glossary example link * small fixes to examples and docs * some small tweaks to the model annotations Co-authored-by: MohdSiddique Bagwan <[email protected]> Co-authored-by: Shirshanka Das <[email protected]> Co-authored-by: Gabe Lyons <[email protected]>
cccs-tom
pushed a commit
to CybercentreCanada/datahub
that referenced
this pull request
Nov 18, 2022
…ort (datahub-project#6148) * WIP * updated snapshot * merge * while creating BusinessGlossaryConfig object, the version field always get set to None * WIP * lint fix * remove field * doc update * rename the fields * review comments * lintFix * Fix the business glossary example link * small fixes to examples and docs * some small tweaks to the model annotations Co-authored-by: MohdSiddique Bagwan <[email protected]> Co-authored-by: Shirshanka Das <[email protected]> Co-authored-by: Gabe Lyons <[email protected]>
gabe-lyons
added a commit
to gabe-lyons/datahub
that referenced
this pull request
Jun 13, 2023
…ort (datahub-project#6148) * WIP * updated snapshot * merge * while creating BusinessGlossaryConfig object, the version field always get set to None * WIP * lint fix * remove field * doc update * rename the fields * review comments * lintFix * Fix the business glossary example link * small fixes to examples and docs * some small tweaks to the model annotations Co-authored-by: MohdSiddique Bagwan <[email protected]> Co-authored-by: Shirshanka Das <[email protected]> Co-authored-by: Gabe Lyons <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
datahub-business-glossarybusiness_glossary.yml