Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest/lookml): add support for local/remote dependencies #6150

Merged
merged 15 commits into from
Oct 7, 2022
Merged

feat(ingest/lookml): add support for local/remote dependencies #6150

merged 15 commits into from
Oct 7, 2022

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Oct 7, 2022

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Oct 7, 2022
@github-actions
Copy link

github-actions bot commented Oct 7, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       8 files  ±0         8 suites  ±0   1h 0m 45s ⏱️ +26s
   732 tests ±0     730 ✔️ ±0  2 💤 ±0  0 ❌ ±0 
1 466 runs  ±0  1 462 ✔️ ±0  4 💤 ±0  0 ❌ ±0 

Results for commit 1db2097. ± Comparison against base commit 0f04cd6.

♻️ This comment has been updated with latest results.

shirshanka
shirshanka approved these changes Oct 7, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link

github-actions bot commented Oct 7, 2022

Unit Test Results (build & test)

597 tests  ±0   593 ✔️ ±0   11m 46s ⏱️ +3s
147 suites ±0       4 💤 ±0 
147 files   ±0       0 ❌ ±0 

Results for commit 72e0412. ± Comparison against base commit 0f04cd6.

@shirshanka shirshanka merged commit 3001407 into datahub-project:master Oct 7, 2022
@hsheth2 hsheth2 deleted the lookml-remote-includes branch October 7, 2022 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsheth2 @shirshanka