Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(secrets) Allow creating secrets with multiline values in the UI #6169

Conversation

chriscollins3456
Copy link
Collaborator

@chriscollins3456 chriscollins3456 commented Oct 11, 2022

Previously we had a regular input as the value field for secrets. Then we changed that to type "Password" so that the browser doesn't automatically remember the value (for security reasons). However we also want to allow mutliline secret values (like ssh keys) so the values field is now a textarea. Browsers don't automatically save textarea values like they do for inputs, so we will be good there security-wise. Just to be safe I put `autoComplete="false" to ensure the browser isn't saving this value.

On top of that I fixed a bug where after you save a secret and open up the modal again, the old values remained populated. We needed to be calling form.resetValues as well as resetting the state.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Oct 11, 2022
@github-actions
Copy link

Unit Test Results (build & test)

597 tests  ±0   593 ✔️ ±0   11m 58s ⏱️ -1s
147 suites ±0       4 💤 ±0 
147 files   ±0       0 ±0 

Results for commit a235793. ± Comparison against base commit 95d1e01.

@aditya-radhakrishnan aditya-radhakrishnan merged commit c0d42de into datahub-project:master Oct 11, 2022
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants