feat(secrets) Allow creating secrets with multiline values in the UI #6169
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we had a regular input as the value field for secrets. Then we changed that to type "Password" so that the browser doesn't automatically remember the value (for security reasons). However we also want to allow mutliline secret values (like ssh keys) so the values field is now a textarea. Browsers don't automatically save textarea values like they do for inputs, so we will be good there security-wise. Just to be safe I put `autoComplete="false" to ensure the browser isn't saving this value.
On top of that I fixed a bug where after you save a secret and open up the modal again, the old values remained populated. We needed to be calling
form.resetValues
as well as resetting the state.Checklist