Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest): allow selfsigned certificate in s3 source #6179

Merged
merged 1 commit into from
Oct 15, 2022
Merged

feat(ingest): allow selfsigned certificate in s3 source #6179

merged 1 commit into from
Oct 15, 2022

Conversation

mayurinehate
Copy link
Collaborator

Fixes #5307

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Oct 12, 2022
@github-actions
Copy link

github-actions bot commented Oct 12, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       8 files  ±0         8 suites  ±0   57m 13s ⏱️ + 2m 50s
   736 tests ±0     734 ✔️ ±0  2 💤 ±0  0 ❌ ±0 
1 474 runs  ±0  1 470 ✔️ ±0  4 💤 ±0  0 ❌ ±0 

Results for commit 1ff9ba5. ± Comparison against base commit 0162074.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 12, 2022 •
edited
Loading

Unit Test Results (build & test)

597 tests  ±0   593 ✔️ ±0   11m 41s ⏱️ -2s
147 suites ±0       4 💤 ±0 
147 files   ±0       0 ❌ ±0 

Results for commit 1ff9ba5. ± Comparison against base commit 0162074.

♻️ This comment has been updated with latest results.

@mayurinehate mayurinehate marked this pull request as ready for review October 13, 2022 09:19
@mayurinehate mayurinehate force-pushed the s3_selfsigned_support branch from 1fd9f1d to 1ff9ba5 Compare October 13, 2022 09:19
shirshanka
shirshanka approved these changes Oct 15, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit afac3a9 into datahub-project:master Oct 15, 2022
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
@mayurinehate @cccs-tom
feat(ingest): s3 - allow selfsigned certificate (datahub-project#6179)
8d5e726 
Fixes datahub-project#5307
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
@mayurinehate @cccs-tom
feat(ingest): s3 - allow selfsigned certificate (datahub-project#6179)
2a36e9e 
Fixes datahub-project#5307
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Please allow selfsigned ca-certs for S3 source
2 participants
@mayurinehate @shirshanka