Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest): upgrade feast #6186

Merged
merged 3 commits into from
Nov 3, 2022
Merged

feat(ingest): upgrade feast #6186

merged 3 commits into from
Nov 3, 2022

Conversation

cburroughs
Copy link
Contributor

@cburroughs cburroughs commented Oct 12, 2022 •
edited by hsheth2
Loading

Upgrade feast from 0.18, which encompasses a variety of api changes summarized at
https://docs.feast.dev/v/v0.25-branch/how-to-guides/automated-feast-upgrade

In addition to the upstream features and bugfixes, this allows rudimentary support for a SnowflakeSource to be enabled and specifying the path of the feature_store config file.

NOTE: feast apply was run to regenerate registry.db

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@cburroughs
feat(ingest): upgrade feast
023c3c7 
Upgrade feast from 0.18, which encompasses a variety of api changes
summarized at
https://docs.feast.dev/v/v0.25-branch/how-to-guides/automated-feast-upgrade

In addition to the upstream features and bugfixes, this allows
rudimentary support for a SnowflakeSource to be enabled and specifying
the path of the feature_store config file.

NOTE: `feast apply` was run to regenerate registry.db
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Oct 12, 2022
@github-actions
Copy link

github-actions bot commented Oct 12, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       8 files         8 suites   1h 0m 3s ⏱️
   755 tests    752 ✔️ 3 💤 0 ❌
1 512 runs  1 505 ✔️ 7 💤 0 ❌

Results for commit 68c02b4.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 12, 2022 •
edited
Loading

Unit Test Results (build & test)

602 tests  ±0   598 ✔️ ±0   11m 43s ⏱️ -19s
149 suites ±0       4 💤 ±0 
149 files   ±0       0 ❌ ±0 

Results for commit 68c02b4. ± Comparison against base commit aa06f31.

♻️ This comment has been updated with latest results.

@cburroughs
Copy link
Contributor Author

All of the failing CI jobs appear to be Python 3.7 specific. The minimum version that feast supports is 3.8 so I'm not sure if there is a path forward here.

@maggiehays maggiehays added the community-contribution PR or Issue raised by member(s) of DataHub Community label Oct 13, 2022
@shirshanka
Copy link
Contributor

seems like you would have the mark the tests as skipped for 3.7, do you know how to accomplish that?

@cburroughs
Copy link
Contributor Author

seems like you would have the mark the tests as skipped for 3.7, do you know how to accomplish that?

I do not. if I'm reading the log github log right, the workfows fail on package installation. So something more than just @pytest.mark.skipif would be needed.

@maggiehays maggiehays added the hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ label Oct 21, 2022
@hsheth2
Copy link
Collaborator

hsheth2 commented Nov 3, 2022

@cburroughs I've tried adding a guard in the setup script and in the pytest - let's see if that makes it through CI

hsheth2
hsheth2 approved these changes Nov 3, 2022
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks fine, so we're ok to merge as long as it passes CI

@hsheth2 hsheth2 merged commit 39c84c2 into datahub-project:master Nov 3, 2022
@cburroughs
Copy link
Contributor Author

@cburroughs I've tried adding a guard in the setup script and in the pytest - let's see if that makes it through CI

Thank you!

cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
@cburroughs @hsheth2 @cccs-tom
feat(ingest): upgrade feast (datahub-project#6186)
c0e4a47 
Co-authored-by: Harshal Sheth <[email protected]>
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
@cburroughs @hsheth2 @cccs-tom
feat(ingest): upgrade feast (datahub-project#6186)
d1b1b44 
Co-authored-by: Harshal Sheth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cburroughs @shirshanka @hsheth2 @maggiehays