Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest): bigquery-beta - Parsing view ddl definition for lineage #6187

Merged
merged 4 commits into from
Oct 13, 2022
Merged

feat(ingest): bigquery-beta - Parsing view ddl definition for lineage #6187

merged 4 commits into from
Oct 13, 2022

Conversation

treff7es
Copy link
Contributor

  • Parsing view ddl definition for lineage
  • Fixing lineage generation when edge was not generated if query contained view and dataset as well
  • Changing default values

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Oct 12, 2022
@treff7es
Copy link
Contributor Author

CleanShot 2022-10-12 at 23 56 12@2x
CleanShot 2022-10-12 at 23 57 11@2x

hsheth2
hsheth2 approved these changes Oct 12, 2022
View reviewed changes
metadata-ingestion/src/datahub/ingestion/source/bigquery_v2/bigquery_config.py Outdated
description="Number of table queried in batch when getting metadata. This is a low leve config propert which should be touched with care. This restriction needed because we query partitions system view which throws error if we try to touch too many tables.",
)
column_limit: int = Field(
default=1000,
default=100,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems pretty low?

@github-actions
Copy link

Unit Test Results (metadata ingestion)

       8 files         8 suites   57m 49s ⏱️
   736 tests    734 ✔️ 2 💤 0 ❌
1 474 runs  1 470 ✔️ 4 💤 0 ❌

Results for commit e51680c.

@github-actions
Copy link

Unit Test Results (build & test)

597 tests  ±0   593 ✔️ ±0   11m 51s ⏱️ -4s
147 suites ±0       4 💤 ±0 
147 files   ±0       0 ❌ ±0 

Results for commit e51680c. ± Comparison against base commit c0d42de.

@shirshanka shirshanka merged commit 6e34cd6 into datahub-project:master Oct 13, 2022
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
@treff7es @shirshanka @cccs-tom
feat(ingest): bigquery-beta - Parsing view ddl definition for lineage (…
3378240 
…datahub-project#6187)

Co-authored-by: Shirshanka Das <[email protected]>
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
@treff7es @shirshanka @cccs-tom
feat(ingest): bigquery-beta - Parsing view ddl definition for lineage (…
115bed4 
…datahub-project#6187)

Co-authored-by: Shirshanka Das <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@treff7es @hsheth2 @shirshanka