Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest/tableau): emit status aspects + streamline stateful ingestion #6188

Merged
merged 1 commit into from
Oct 13, 2022
Merged

feat(ingest/tableau): emit status aspects + streamline stateful ingestion #6188

merged 1 commit into from
Oct 13, 2022

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Oct 12, 2022 •
edited
Loading

  • Emit status aspects for all entities
  • Track containers in stateful ingestion
  • Simplify stateful ingestion code

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Oct 12, 2022
@hsheth2
feat(ingest): fix tableau stateful ingestion
1a6bb5d 
- Emit status aspects for all entities
- Track containers in stateful ingestion
- Simplify stateful ingestion code
@hsheth2 hsheth2 force-pushed the tableau-stateful-ingest-status branch from ef89764 to 1a6bb5d Compare October 12, 2022 22:37
@hsheth2 hsheth2 changed the title feat(ingest/tableau): support dashboard tags feat(ingest/tableau): emit status aspects + streamline stateful ingestion Oct 12, 2022
@github-actions
Copy link

Unit Test Results (build & test)

597 tests  ±0   593 ✔️ ±0   11m 42s ⏱️ -14s
147 suites ±0       4 💤 ±0 
147 files   ±0       0 ❌ ±0 

Results for commit 1a6bb5d. ± Comparison against base commit c7cc0af.

@github-actions
Copy link

Unit Test Results (metadata ingestion)

       8 files  ±0         8 suites  ±0   54m 42s ⏱️ - 3m 38s
   732 tests ±0     730 ✔️ ±0  2 💤 ±0  0 ❌ ±0 
1 466 runs  ±0  1 462 ✔️ ±0  4 💤 ±0  0 ❌ ±0 

Results for commit 1a6bb5d. ± Comparison against base commit c7cc0af.

@hsheth2 hsheth2 merged commit 8030ac8 into datahub-project:master Oct 13, 2022
@hsheth2 hsheth2 deleted the tableau-stateful-ingest-status branch October 13, 2022 19:48
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
@hsheth2 @cccs-tom
feat(ingest/tableau): emit status aspects + streamline stateful inges…
7ccc491 
…tion (datahub-project#6188)
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
@hsheth2 @cccs-tom
feat(ingest/tableau): emit status aspects + streamline stateful inges…
ba33fec 
…tion (datahub-project#6188)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-leifker david-leifker david-leifker approved these changes

@aditya-radhakrishnan aditya-radhakrishnan aditya-radhakrishnan approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hsheth2 @aditya-radhakrishnan @david-leifker