Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest) - bigquery-beta - Using table ref instead of table id #6193

Merged
merged 1 commit into from
Oct 13, 2022
Merged

fix(ingest) - bigquery-beta - Using table ref instead of table id #6193

merged 1 commit into from
Oct 13, 2022

Conversation

treff7es
Copy link
Contributor

Using table ref instead of table id as earlier this caused to not add table lineage edges

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Oct 13, 2022
anshbansal
anshbansal approved these changes Oct 13, 2022
View reviewed changes
Copy link
Collaborator

@anshbansal anshbansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

Unit Test Results (metadata ingestion)

       8 files  ±0         8 suites  ±0   59m 17s ⏱️ +51s
   736 tests ±0     734 ✔️ ±0  2 💤 ±0  0 ❌ ±0 
1 474 runs  ±0  1 470 ✔️ ±0  4 💤 ±0  0 ❌ ±0 

Results for commit 4dabbf3. ± Comparison against base commit 6e34cd6.

@github-actions
Copy link

Unit Test Results (build & test)

597 tests  ±0   593 ✔️ ±0   11m 46s ⏱️ -2s
147 suites ±0       4 💤 ±0 
147 files   ±0       0 ❌ ±0 

Results for commit 4dabbf3. ± Comparison against base commit 6e34cd6.

@treff7es treff7es merged commit 0162074 into datahub-project:master Oct 13, 2022
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
@treff7es @cccs-tom
fix(ingest) - bigquery-beta - Using table ref instead of table id (da…
3e291be 
…tahub-project#6193)
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
@treff7es @cccs-tom
fix(ingest) - bigquery-beta - Using table ref instead of table id (da…
a970f71 
…tahub-project#6193)
@treff7es treff7es deleted the bqv2-lin-fix branch February 8, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anshbansal anshbansal anshbansal approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@treff7es @anshbansal