Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): catch errors when profiling for sample values #6194

Merged
merged 1 commit into from
Oct 15, 2022
Merged

fix(ingest): catch errors when profiling for sample values #6194

merged 1 commit into from
Oct 15, 2022

Conversation

mayurinehate
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Oct 13, 2022
@github-actions
Copy link

Unit Test Results (metadata ingestion)

       8 files  ±0         8 suites  ±0   56m 9s ⏱️ + 1m 46s
   736 tests ±0     734 ✔️ ±0  2 💤 ±0  0 ❌ ±0 
1 474 runs  ±0  1 470 ✔️ ±0  4 💤 ±0  0 ❌ ±0 

Results for commit 6113eac. ± Comparison against base commit 0162074.

@github-actions
Copy link

Unit Test Results (build & test)

597 tests  ±0   593 ✔️ ±0   11m 56s ⏱️ +13s
147 suites ±0       4 💤 ±0 
147 files   ±0       0 ❌ ±0 

Results for commit 6113eac. ± Comparison against base commit 0162074.

shirshanka
shirshanka approved these changes Oct 15, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit 3fc6364 into datahub-project:master Oct 15, 2022
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
@mayurinehate @cccs-tom
fix(ingest): catch errors when profiling for sample values (datahub-p…
921c520 
…roject#6194)
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
@mayurinehate @cccs-tom
fix(ingest): catch errors when profiling for sample values (datahub-p…
173f055 
…roject#6194)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mayurinehate @shirshanka