feat(ingestion-ui) Add new form for the bigquery-beta connector #6200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aditya-radhakrishnan
approved these changes
Oct 13, 2022
| @@ -19,17 +19,12 @@ const StyledRemoveIcon = styled(MinusCircleOutlined)` | |||
| margin-left: 10px; | |||
| `; | |||
|
|
|||
| interface ListFieldProps { | |||
| interface CommonFieldProps { | |||
There was a problem hiding this comment.
I like this renaming
| return setFieldValueOnRecipe(recipe, null, startTimeFieldPath); | ||
| } | ||
| const isoDateString = value.toISOString(); | ||
| const formattedDateString = isoDateString |
There was a problem hiding this comment.
Can you see this being used elsewhere (and should it be in a utils file)?
There was a problem hiding this comment.
I certainly can - good call
cccs-tom
pushed a commit
to CybercentreCanada/datahub
that referenced
this pull request
Nov 18, 2022
cccs-tom
pushed a commit
to CybercentreCanada/datahub
that referenced
this pull request
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new form for the
bigquery-betaconnector. It's similar to the regularbigqueryform but with a few tweaks, including new allow/deny patterns, and a new field type (DATE).This PR doesn't include
bigquery-betaintosources.jsonquite yet so it won't be visible in the UI until we flip the switch. Getting this in there now will give us flexibility in how/when we roll this out, though.the form:
Checklist