Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): use corpGroup instead of corpgroup #6202

Merged
merged 1 commit into from
Oct 15, 2022
Merged

fix(ingest): use corpGroup instead of corpgroup #6202

merged 1 commit into from
Oct 15, 2022

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Oct 13, 2022

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added docs Issues and Improvements to docs ingestion PR or Issue related to the ingestion of metadata labels Oct 13, 2022
@github-actions
Copy link

Unit Test Results (metadata ingestion)

       8 files         8 suites   58m 19s ⏱️
   737 tests    735 ✔️ 2 💤 0 ❌
1 476 runs  1 472 ✔️ 4 💤 0 ❌

Results for commit aa81ff6.

@github-actions
Copy link

Unit Test Results (build & test)

597 tests  ±0   593 ✔️ ±0   11m 57s ⏱️ +17s
147 suites ±0       4 💤 ±0 
147 files   ±0       0 ❌ ±0 

Results for commit aa81ff6. ± Comparison against base commit 9d5851c.

shirshanka
shirshanka approved these changes Oct 15, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit 1b2b282 into datahub-project:master Oct 15, 2022
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
@hsheth2 @cccs-tom
fix(ingest): use corpGroup instead of corpgroup (datahub-project#6202)
b652d26
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
@hsheth2 @cccs-tom
fix(ingest): use corpGroup instead of corpgroup (datahub-project#6202)
be90dce
@hsheth2 hsheth2 deleted the corpGroup branch February 14, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
docs Issues and Improvements to docs ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsheth2 @shirshanka