Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Tag Modal Issue: Clear the input value on press. #6212

Merged
merged 4 commits into from
Oct 20, 2022
Merged

Create Tag Modal Issue: Clear the input value on press. #6212

merged 4 commits into from
Oct 20, 2022

Conversation

Ankit-Keshari-Vituity
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Oct 17, 2022
@github-actions
Copy link

github-actions bot commented Oct 17, 2022 •
edited
Loading

Unit Test Results (build & test)

597 tests  ±0   593 ✔️ ±0   11m 38s ⏱️ -20s
147 suites ±0       4 💤 ±0 
147 files   ±0       0 ❌ ±0 

Results for commit c689c1b. ± Comparison against base commit 73fd358.

♻️ This comment has been updated with latest results.

chriscollins3456
chriscollins3456 reviewed Oct 17, 2022
View reviewed changes
datahub-web-react/src/app/shared/tags/AddTagsTermsModal.tsx Outdated
@@ -210,6 +211,7 @@ export default function EditTagTermsModal({
if (isValidTagName(inputValue)) {
setShowCreateModal(true);
}
setInputValue('');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and tests are failing because of this line I believe.

If you clear the input value and save the new term, we submit an empty string to the backend on creating the tag.

You can test by trying to create a new tag with this code.

chriscollins3456
chriscollins3456 approved these changes Oct 19, 2022
View reviewed changes
Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@chriscollins3456 chriscollins3456 merged commit bd217f8 into datahub-project:master Oct 20, 2022
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
@Ankit-Keshari-Vituity @cccs-tom
Create Tag Modal Issue: Clear the input value on press. (datahub-proj…
d77bda7 
…ect#6212)
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
@Ankit-Keshari-Vituity @cccs-tom
Create Tag Modal Issue: Clear the input value on press. (datahub-proj…
3596af8 
…ect#6212)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriscollins3456 chriscollins3456 chriscollins3456 approved these changes

Assignees
No one assigned
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ankit-Keshari-Vituity @chriscollins3456