Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(glossary) Improve performance when getting root glossary terms #6214

Conversation

chriscollins3456
Copy link
Collaborator

@chriscollins3456 chriscollins3456 commented Oct 17, 2022

Similar to the previous glossary performance PR, this reduces overfetching when getting root glossary terms to minimize the number of trips to our graph index. Now, fetch only the fields we need for the UI.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Oct 17, 2022
@github-actions
Copy link

Unit Test Results (build & test)

597 tests  ±0   593 ✔️ ±0   11m 43s ⏱️ -15s
147 suites ±0       4 💤 ±0 
147 files   ±0       0 ±0 

Results for commit 0bb4ff6. ± Comparison against base commit 73fd358.

@chriscollins3456 chriscollins3456 merged commit 956bee9 into datahub-project:master Oct 17, 2022
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants