feat(telemetry): add telemetry events to the glossary, domains, and managed ingestion pages #6216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabe-lyons
reviewed
Oct 18, 2022
|
|
||
| private static final Set<String> ALLOWED_EVENT_FIELDS = new HashSet<>( | ||
| ImmutableList.of(EVENT_TYPE_FIELD, SIGN_UP_TITLE_FIELD, ENTITY_TYPE_FIELD, ENTITY_TYPE_FILTER_FIELD, | ||
| PAGE_NUMBER_FIELD, PAGE_FIELD, TOTAL_FIELD, INDEX_FIELD, RESULT_TYPE_FIELD, RENDER_ID_FIELD, MODULE_ID_FIELD, | ||
| RENDER_TYPE_FIELD, SCENARIO_TYPE_FIELD, SECTION_FIELD, ACCESS_TOKEN_TYPE_FIELD, DURATION_FIELD, | ||
| ROLE_URN_FIELD, POLICY_URN_FIELD)); | ||
| ROLE_URN_FIELD, POLICY_URN_FIELD, PARENT_NODE_URN_FIELD, SOURCE_TYPE_FIELD, INTERVAL_FIELD)); |
There was a problem hiding this comment.
We should hash PARENT_NODE_URN_FIELD
There was a problem hiding this comment.
Good point! Done :)
aditya-radhakrishnan
force-pushed
the
ar--misc-telemetry
branch
from
36f6f5d to
7172a5d
Compare
…anaged ingestion pages
aditya-radhakrishnan
force-pushed
the
ar--misc-telemetry
branch
from
7172a5d to
174e973
Compare
cccs-tom
pushed a commit
to CybercentreCanada/datahub
that referenced
this pull request
Nov 18, 2022
…anaged ingestion pages (datahub-project#6216) Co-authored-by: John Joyce <[email protected]>
cccs-tom
pushed a commit
to CybercentreCanada/datahub
that referenced
this pull request
Nov 18, 2022
…anaged ingestion pages (datahub-project#6216) Co-authored-by: John Joyce <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist