Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(oidc): change default oidc username claim to be email #6220

Merged
merged 1 commit into from
Oct 24, 2022
Merged

fix(oidc): change default oidc username claim to be email #6220

merged 1 commit into from
Oct 24, 2022

Conversation

aditya-radhakrishnan
Copy link
Contributor

@aditya-radhakrishnan aditya-radhakrishnan commented Oct 17, 2022 •
edited
Loading

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Oct 17, 2022
@github-actions
Copy link

Unit Test Results (build & test)

597 tests  ±0   593 ✔️ ±0   12m 14s ⏱️ +31s
147 suites ±0       4 💤 ±0 
147 files   ±0       0 ❌ ±0 

Results for commit 792d22b. ± Comparison against base commit bed59d2.

@jjoyce0510 jjoyce0510 merged commit d905cdf into datahub-project:master Oct 24, 2022
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
@aditya-radhakrishnan @cccs-tom
fix(oidc): change default oidc username claim to be email (datahub-pr…
fedfe1b 
…oject#6220)
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
@aditya-radhakrishnan @cccs-tom
fix(oidc): change default oidc username claim to be email (datahub-pr…
190e5c4 
…oject#6220)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

Assignees
No one assigned
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aditya-radhakrishnan @jjoyce0510