Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest): bigquery - Promoting bigquery-beta to bigquery source #6222

Merged
merged 4 commits into from
Oct 26, 2022
Merged

feat(ingest): bigquery - Promoting bigquery-beta to bigquery source #6222

merged 4 commits into from
Oct 26, 2022

Conversation

treff7es
Copy link
Contributor

Moving bigquery-beta to bigquery source
Moving bigquery source to bigquery-legacy source

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@treff7es
Moving bigquery source to bigquery-legacy source
34ef64f 
Mocing bigquery-beta to bigquery source
@github-actions github-actions bot added docs Issues and Improvements to docs ingestion PR or Issue related to the ingestion of metadata labels Oct 18, 2022
@github-actions
Copy link

github-actions bot commented Oct 18, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       8 files         8 suites   53m 53s ⏱️
   748 tests    745 ✔️ 3 💤 0 ❌
1 498 runs  1 492 ✔️ 6 💤 0 ❌

Results for commit f5b537c.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 18, 2022 •
edited
Loading

Unit Test Results (build & test)

597 tests  ±0   593 ✔️ ±0   11m 41s ⏱️ -2s
147 suites ±0       4 💤 ±0 
147 files   ±0       0 ❌ ±0 

Results for commit f5b537c. ± Comparison against base commit bed59d2.

♻️ This comment has been updated with latest results.

@shirshanka
Copy link
Contributor

@chriscollins3456: what changes do we need on the ui ingestion forms to move this?

shirshanka
shirshanka approved these changes Oct 26, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit 94fae0a into datahub-project:master Oct 26, 2022
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
@treff7es @shirshanka @cccs-tom
feat(ingest): bigquery - Promoting bigquery-beta to bigquery source (d…
8d1e731 
…atahub-project#6222)

Co-authored-by: Shirshanka Das <[email protected]>
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
@treff7es @shirshanka @cccs-tom
feat(ingest): bigquery - Promoting bigquery-beta to bigquery source (d…
da109ca 
…atahub-project#6222)

Co-authored-by: Shirshanka Das <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
docs Issues and Improvements to docs ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@treff7es @shirshanka