Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(build): allow image tag via env, fix requirements #6237

Merged
merged 2 commits into from
Oct 19, 2022
Merged

fix(build): allow image tag via env, fix requirements #6237

merged 2 commits into from
Oct 19, 2022

Conversation

anshbansal
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@anshbansal anshbansal requested a review from pedro93 October 19, 2022 06:29
@github-actions github-actions bot added the devops PR or Issue related to DataHub backend & deployment label Oct 19, 2022
@anshbansal anshbansal changed the title fix requirements for build fix(build): allow image tag via env, fix requirements Oct 19, 2022
@anshbansal anshbansal mentioned this pull request Oct 19, 2022
Merged
5 tasks
treff7es
treff7es approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anshbansal anshbansal merged commit 98eba90 into datahub-project:master Oct 19, 2022
@anshbansal anshbansal deleted the fix-requirements-smoke-test branch October 19, 2022 06:56
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
@anshbansal @cccs-tom
fix(build): allow image tag via env, fix requirements (datahub-projec…
d0d1605 
…t#6237)
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
@anshbansal @cccs-tom
fix(build): allow image tag via env, fix requirements (datahub-projec…
5482420 
…t#6237)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treff7es treff7es treff7es approved these changes

@pedro93 pedro93 Awaiting requested review from pedro93

Assignees
No one assigned
Labels
devops PR or Issue related to DataHub backend & deployment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anshbansal @treff7es