Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only add failure report on exception and process view and table #6242

Merged
merged 2 commits into from
Oct 26, 2022
Merged

fix: only add failure report on exception and process view and table #6242

merged 2 commits into from
Oct 26, 2022

Conversation

abelstam12
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Oct 19, 2022
@abelstam12
Copy link
Contributor Author

@treff7es maybe you can check if this is indeed a fix

@github-actions
Copy link

github-actions bot commented Oct 19, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       8 files  ±0         8 suites  ±0   1h 0m 35s ⏱️ + 5m 56s
   748 tests ±0     745 ✔️ ±0  3 💤 ±0  0 ❌ ±0 
1 498 runs  ±0  1 492 ✔️ ±0  6 💤 ±0  0 ❌ ±0 

Results for commit bdd8cbd. ± Comparison against base commit c5fc2ea.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 19, 2022 •
edited
Loading

Unit Test Results (build & test)

597 tests  ±0   593 ✔️ ±0   11m 46s ⏱️ -6s
147 suites ±0       4 💤 ±0 
147 files   ±0       0 ❌ ±0 

Results for commit bdd8cbd. ± Comparison against base commit c5fc2ea.

♻️ This comment has been updated with latest results.

@maggiehays maggiehays added community-contribution PR or Issue raised by member(s) of DataHub Community hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ labels Oct 21, 2022
treff7es
treff7es requested changes Oct 24, 2022
View reviewed changes
Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, can you revert the if statement change then I can approve your fix.

metadata-ingestion/src/datahub/ingestion/source/bigquery_v2/lineage.py Outdated Show resolved Hide resolved
@abelstam12 abelstam12 force-pushed the lineage-sql-parser-also-process-only-view branch from f98e919 to c3b77d4 Compare October 24, 2022 10:32
@abelstam12 abelstam12 requested a review from treff7es October 24, 2022 10:36
treff7es
treff7es approved these changes Oct 24, 2022
View reviewed changes
Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the fix @abelstam12

@shirshanka shirshanka merged commit cc88c87 into datahub-project:master Oct 26, 2022
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
@abelstam12 @cccs-tom
fix(ingest): bigquery - only register failure on exception (datahub-p…
81bf49d 
…roject#6242)
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
@abelstam12 @cccs-tom
fix(ingest): bigquery - only register failure on exception (datahub-p…
2ea0b43 
…roject#6242)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treff7es treff7es treff7es approved these changes

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abelstam12 @treff7es @shirshanka @maggiehays