Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest): hive-on-presto - Add option to properly filter hive schemas #6247

Merged
merged 3 commits into from
Oct 20, 2022
Merged

feat(ingest): hive-on-presto - Add option to properly filter hive schemas #6247

merged 3 commits into from
Oct 20, 2022

Conversation

treff7es
Copy link
Contributor

Don't create schema container if it is filtered out

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@treff7es
Add option to properly filter hive schemas
e988791 
Don't create schema container if it is filtered out
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Oct 20, 2022
@github-actions
Copy link

Unit Test Results (metadata ingestion)

       8 files         8 suites   58m 16s ⏱️
   747 tests    744 ✔️ 3 💤 0 ❌
1 496 runs  1 490 ✔️ 6 💤 0 ❌

Results for commit e988791.

@github-actions
Copy link

Unit Test Results (build & test)

597 tests  ±0   593 ✔️ ±0   11m 54s ⏱️ -1s
147 suites ±0       4 💤 ±0 
147 files   ±0       0 ❌ ±0 

Results for commit e988791. ± Comparison against base commit bd217f8.

shirshanka
shirshanka approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@treff7es treff7es changed the title feat(ingest): hive-on-presot - Add option to properly filter hive schemas feat(ingest): hive-on-presto - Add option to properly filter hive schemas Oct 20, 2022
@treff7es treff7es merged commit 6757076 into datahub-project:master Oct 20, 2022
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
@treff7es @cccs-tom
feat(ingest): hive-on-presto - Add option to properly filter hive dat…
00dde11 
…abase (datahub-project#6247)
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
@treff7es @cccs-tom
feat(ingest): hive-on-presto - Add option to properly filter hive dat…
dd8cb5e 
…abase (datahub-project#6247)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@treff7es @shirshanka