Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(metrics): add metrics around search caching #6255

Merged
merged 4 commits into from
Oct 24, 2022
Merged

feat(metrics): add metrics around search caching #6255

merged 4 commits into from
Oct 24, 2022

Conversation

RyanHolstien
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@RyanHolstien RyanHolstien added the devops PR or Issue related to DataHub backend & deployment label Oct 20, 2022
@RyanHolstien RyanHolstien requested a review from szalai1 October 20, 2022 21:07
@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX and removed devops PR or Issue related to DataHub backend & deployment labels Oct 20, 2022
@github-actions
Copy link

github-actions bot commented Oct 20, 2022 •
edited
Loading

Unit Test Results (build & test)

597 tests  ±0   593 ✔️ ±0   11m 45s ⏱️ -19s
147 suites ±0       4 💤 ±0 
147 files   ±0       0 ❌ ±0 

Results for commit f7bf3cc. ± Comparison against base commit 6757076.

♻️ This comment has been updated with latest results.

jjoyce0510
jjoyce0510 approved these changes Oct 24, 2022
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Nice work!

@jjoyce0510 jjoyce0510 merged commit 762c903 into datahub-project:master Oct 24, 2022
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
@RyanHolstien @cccs-tom
feat(metrics): add metrics around search caching (datahub-project#6255)
56b8322
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
@RyanHolstien @cccs-tom
feat(metrics): add metrics around search caching (datahub-project#6255)
f61f02a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

@szalai1 szalai1 Awaiting requested review from szalai1

Assignees
No one assigned
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RyanHolstien @jjoyce0510