Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(lineage): Updating Lineage feature guide #6257

Merged
merged 8 commits into from
Jan 25, 2023
Merged

docs(lineage): Updating Lineage feature guide #6257

merged 8 commits into from
Jan 25, 2023

Conversation

maggiehays
Copy link
Collaborator

@maggiehays maggiehays commented Oct 21, 2022 •
edited
Loading

Expands on manual lineage guide to include details around managing lineage edges via API; simplifies sidebar navigation to remove unnecessary subdirectory in Enrich Metadata section

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the docs Issues and Improvements to docs label Oct 21, 2022
jjoyce0510
jjoyce0510 reviewed Jan 10, 2023
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome~! We have another Lineage feature guide written by Chris that focuses on UI lineage editing. Maybe we can merge this into that? (It was just merged)

@maggiehays maggiehays marked this pull request as ready for review January 14, 2023 00:45
@maggiehays
Copy link
Collaborator Author

@chriscollins3456 @jjoyce0510 this is ready for final review. One thing to consider -- this PR removes intro.md which is our legacy entry point for lineage.. it was extremely low value, but it will result in a broken link. Should we think through redirects?

jjoyce0510
jjoyce0510 reviewed Jan 25, 2023
View reviewed changes
docs/lineage/lineage-feature-guide.md

* [lineage_chart_dashboard.py](../../metadata-ingestion/examples/library/lineage_chart_dashboard.py) - emits the chart-to-dashboard lineage via REST as MetadataChangeProposalWrapper.

### Using Chart-to-Dataset Lineage
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this is much better.

@maggiehays maggiehays merged commit 0426f5c into datahub-project:master Jan 25, 2023
ericyomi pushed a commit to ericyomi/datahub that referenced this pull request Feb 8, 2023
@maggiehays
docs(lineage): Updating Lineage feature guide (datahub-project#6257)
da8a4c5
oleg-ruban pushed a commit to RChygir/datahub that referenced this pull request Feb 28, 2023
@maggiehays
docs(lineage): Updating Lineage feature guide (datahub-project#6257)
5de3d18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriscollins3456 chriscollins3456 chriscollins3456 left review comments

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

@laulpogan laulpogan Awaiting requested review from laulpogan

Assignees
No one assigned
Labels
docs Issues and Improvements to docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maggiehays @jjoyce0510 @chriscollins3456