Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest): looker - deps, column level lineage fixes #6271

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

shirshanka
Copy link
Contributor

This PR fixes a few issues:

  • looker connector dependencies: combined dependencies for both looker and lookml
  • fixes explore -> view lineage for fields
  • improves sql parsing for lookml views
  • limits column level lineage inference only for non-sql based views (sql parsing for column level lineage will be addressed later)
  • adds a config flag to control external process spawning for sql parsing

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Oct 24, 2022
@github-actions
Copy link

Unit Test Results (metadata ingestion)

       8 files         8 suites   1h 2m 13s ⏱️
   748 tests    745 ✔️ 3 💤 0
1 498 runs  1 492 ✔️ 6 💤 0

Results for commit 3af63e7.

@github-actions
Copy link

Unit Test Results (build & test)

597 tests  +91   593 ✔️ +87   12m 15s ⏱️ + 11m 5s
147 suites +31       4 💤 +  4 
147 files   +31       0 ±  0 

Results for commit 3af63e7. ± Comparison against base commit 16fdd77.

Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@treff7es treff7es merged commit c5fc2ea into datahub-project:master Oct 24, 2022
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants