Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui) Update bigquery UI ingestion source to be the same as bigquery-beta #6283

Merged
merged 2 commits into from
Oct 31, 2022
Merged

feat(ui) Update bigquery UI ingestion source to be the same as bigquery-beta #6283

merged 2 commits into from
Oct 31, 2022

Conversation

chriscollins3456
Copy link
Collaborator

Display the bigquery-beta form and default recipe for the bigquery source. Done in order to remove the need for bigquery-beta and promote every bigquery source to the new one.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Oct 25, 2022
@github-actions
Copy link

Unit Test Results (build & test)

599 tests  ±0   595 ✔️ ±0   11m 47s ⏱️ -23s
149 suites ±0       4 💤 ±0 
149 files   ±0       0 ❌ ±0 

Results for commit e69692d. ± Comparison against base commit 8e1deb6.

jjoyce0510
jjoyce0510 approved these changes Oct 31, 2022
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- Thanks!

@chriscollins3456 chriscollins3456 merged commit e1c39e5 into datahub-project:master Oct 31, 2022
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
@chriscollins3456 @cccs-tom
feat(ui) Update bigquery UI ingestion source to be the same as bigque…
158482a 
…ry-beta (datahub-project#6283)
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
@chriscollins3456 @cccs-tom
feat(ui) Update bigquery UI ingestion source to be the same as bigque…
6072152 
…ry-beta (datahub-project#6283)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

Assignees
No one assigned
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chriscollins3456 @jjoyce0510