Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest/dbt): lowercase external urns + cleanup config #6289

Merged
merged 2 commits into from
Oct 27, 2022
Merged

fix(ingest/dbt): lowercase external urns + cleanup config #6289

merged 2 commits into from
Oct 27, 2022

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Oct 26, 2022

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Oct 26, 2022
@github-actions
Copy link

Unit Test Results (metadata ingestion)

       8 files         8 suites   1h 1m 9s ⏱️
   748 tests    745 ✔️ 3 💤 0 ❌
1 498 runs  1 492 ✔️ 6 💤 0 ❌

Results for commit 871f3cc.

@github-actions
Copy link

Unit Test Results (build & test)

597 tests  ±0   593 ✔️ ±0   11m 38s ⏱️ -16s
147 suites ±0       4 💤 ±0 
147 files   ±0       0 ❌ ±0 

Results for commit 871f3cc. ± Comparison against base commit 855be25.

shirshanka
shirshanka reviewed Oct 26, 2022
View reviewed changes
metadata-ingestion/src/datahub/ingestion/source/dbt.py
@@ -255,10 +244,6 @@ class DBTConfig(StatefulIngestionConfigBase):
default=False,
description="Use model identifier instead of model name if defined (if not, default to model name).",
)
node_type_pattern: AllowDenyPattern = Field(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this requires updating the updating.md doc as this is a backwards incompatible change.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will update in a follow up PR

shirshanka
shirshanka approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit e27b017 into datahub-project:master Oct 27, 2022
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
@hsheth2 @shirshanka @cccs-tom
fix(ingest): dbt - lowercase external urns + cleanup config (datahub-…
46b0b57 
…project#6289)

Co-authored-by: Shirshanka Das <[email protected]>
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
@hsheth2 @shirshanka @cccs-tom
fix(ingest): dbt - lowercase external urns + cleanup config (datahub-…
2aff563 
…project#6289)

Co-authored-by: Shirshanka Das <[email protected]>
@hsheth2 hsheth2 deleted the dbt-urn-lower branch February 14, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsheth2 @shirshanka