feat(ingest): unity-catalog - Unity catalog source #6292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ata/datahub-fork into master+acr-4552-mvp-unity-catalog
- Stateful ingestion - Filtering - More verbose reporting - Domain support - Connection test support - Complex type support
Moving config into separate file
treff7es
changed the title
treff7es
changed the title
github-actions
bot
added
the
ingestion
Unit Test Results (metadata ingestion) 8 files ± 0 8 suites ±0 54m 34s ⏱️ - 2m 17s For more details on these failures and errors, see this check. Results for commit 96bd74c. ± Comparison against base commit 46453e4. ♻️ This comment has been updated with latest results. |
|
|
shirshanka
reviewed
Oct 30, 2022
| catalog: str | ||
|
|
||
|
|
||
| class UnitySchemaKey(CatalogKey): |
There was a problem hiding this comment.
I'm not a big fan of integration specific classes being added to mcp_builder.py ... we have accumulated a few and need to remove these later IMO
cccs-tom
pushed a commit
to CybercentreCanada/datahub
that referenced
this pull request
Nov 18, 2022
Co-authored-by: MohdSiddique Bagwan <[email protected]> Co-authored-by: Shirshanka Das <[email protected]>
cccs-tom
pushed a commit
to CybercentreCanada/datahub
that referenced
this pull request
Nov 18, 2022
Co-authored-by: MohdSiddique Bagwan <[email protected]> Co-authored-by: Shirshanka Das <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist